On 2014-09-13 10:05, Alan Bateman wrote:
On 12/09/2014 21:48, Mandy Chung wrote:
With the Modular Source Code [1] in JDK 9, the verify-modules target
was added in the build to catch any regression to the module boundaries.
It's important to catch this regression early during jdk development.
This patch proposes to add verify-modules to the default target
and also images target (it was a bug). This will track the time
to determine if the build time becomes an issue.
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8058367/webrev.00/
I assumed that the images target already ran verify-modules, it seems
not. That part looks good to me.
I'm less sure about changing the default target as it adds a few
additional seconds. I wonder if this part should be left out on the
assumption that most people are likely to make sure that images build
before they push.
I would agree with Alan that adding it to images would likely be enough.
/Erik
