I am starting to not to count on most people building images and
inclined to catch any new dependence earlier in the default build
to avoid potential build breakage.
The time for verify-modules is not small and there is potential
performance improvement. I suspect people may use JDK_FILTER,
or sjavac to get fast incremental build time. Perhaps we could
provide a flag to disable verify-modules if they really want
fast build time.
Mandy
On 9/15/14 8:57 AM, Phil Race wrote:
My assumption is the opposite, that most people type 'make' and
nothing more, expecting that if you had to do more to test a code
change builds properly, it would be included in the default target.
If you aren't affecting the images, then you don't expect to need
to build the images.
-phil.
On 9/15/2014 2:48 AM, Erik Joelsson wrote:
On 2014-09-13 10:05, Alan Bateman wrote:
On 12/09/2014 21:48, Mandy Chung wrote:
With the Modular Source Code [1] in JDK 9, the verify-modules target
was added in the build to catch any regression to the module
boundaries.
It's important to catch this regression early during jdk development.
This patch proposes to add verify-modules to the default target
and also images target (it was a bug). This will track the time
to determine if the build time becomes an issue.
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8058367/webrev.00/
I assumed that the images target already ran verify-modules, it
seems not. That part looks good to me.
I'm less sure about changing the default target as it adds a few
additional seconds. I wonder if this part should be left out on the
assumption that most people are likely to make sure that images
build before they push.
I would agree with Alan that adding it to images would likely be enough.
/Erik
