Running with longer timeouts on fast machines makes the testing less responsive (if a test is on its way to timeout it takes longer for us to detect it). Ideally the timeout factor should be tuned according to the machine type we are running on. I’m not sure that is possible, though?
> On 5 dec 2014, at 00:52, David Holmes <david.hol...@oracle.com> wrote: > > Hi Chris, > > Sorry I mis-directed you to send this one to build-dev, as it is a hotspot > test/Makefile fix it should be reviewed by hotspot-dev now cc'd. > > Fix looks good to me. > > Thanks, > David > > On 5/12/2014 6:37 AM, Chris Plummer wrote: >> Please review the following fix to address JPRT timeout issues when >> using -rtests to run hotspot JTReg tests on slow devices. The same logic >> has been in place for jdk/test/Makefile for a while now, so I just >> copied from there to hotspot/test/Makefile. >> >> https://bugs.openjdk.java.net/browse/JDK-8066508 >> http://cr.openjdk.java.net/~cjplummer/8066508/webrev.00/ >> >> thanks, >> >> Chris >>
