On 12/5/14 6:05 AM, Daniel D. Daugherty wrote:
On 12/5/14 2:45 AM, David Holmes wrote:
On 5/12/2014 7:22 PM, David Holmes wrote:
On 5/12/2014 6:11 PM, Staffan Larsen wrote:
Running with longer timeouts on fast machines makes the testing less
responsive (if a test is on its way to timeout it takes longer for us
to detect it). Ideally the timeout factor should be tuned according to
the machine type we are running on. I�m not sure that is possible,
though?
We don't have that level of control unfortunately.
Sorry that's not true. As this is our Makefile we could make the
timeout value platform specific (though remember this is an open
file). And if we have some means of defining a performance metric for
a machine, we could even tune it for the current machine - but I'm
not sure we'd want to go that path anyway. Perhaps a RFE.
What Chris is proposing addresses a current problem and brings
hotspot testing into line with what the JDK testing has been doing
since 2009. :)
I'm fairly certain that VM/SQE nightly tunes the JavaTest/JTREG
timeout factor depending on the machine type or the machine name
itself; I don't know the exact details. I suspect that this is
possible in VM/SQE nightly/Aurora because there is a database
of per-machine info.
It might be possible to do something similar for JPRT if it
tracks information per client machine...
Ok. BTW, I was not suggesting a JPRT fix instead of my above fix in the
near term. I still would like to push my fix and have the timeout for
hotspot/test be on par with jdk/test. I still need one more reviewer.
thanks,
Chris
Dan
David
David
On 5 dec 2014, at 00:52, David Holmes <david.hol...@oracle.com>
wrote:
Hi Chris,
Sorry I mis-directed you to send this one to build-dev, as it is a
hotspot test/Makefile fix it should be reviewed by hotspot-dev now
cc'd.
Fix looks good to me.
Thanks,
David
On 5/12/2014 6:37 AM, Chris Plummer wrote:
Please review the following fix to address JPRT timeout issues when
using -rtests to run hotspot JTReg tests on slow devices. The same
logic
has been in place for jdk/test/Makefile for a while now, so I just
copied from there to hotspot/test/Makefile.
https://bugs.openjdk.java.net/browse/JDK-8066508
http://cr.openjdk.java.net/~cjplummer/8066508/webrev.00/
thanks,
Chris
