> On 7 aug 2015, at 11:24, serguei.spit...@oracle.com wrote: > > Hi Staffan, > > Looks good.
Thanks! > > I'm re-posting the same question in this review: > Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be > removed? No, it is used by some of the demos (mtrace, minst, etc). But they statically link the code so the lib is no longer needed. /Staffan > > Thanks, > Serguei > > > On 8/6/15 11:57 PM, Staffan Larsen wrote: >> Please review the following changes to remove the hprof JVMTI agent. There >> are changes in three different repositories. All tests that used the hprof >> agent has been removed in previous changesets. >> >> Note: This does not remove the ability of the Hotspot VM to output heap >> dumps in the hprof format. >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8046661 >> <https://bugs.openjdk.java.net/browse/JDK-8046661> >> >> top-level changes: http://cr.openjdk.java.net/~sla/8076470/root/webrev.00/ >> <http://cr.openjdk.java.net/%7Esla/8076470/root/webrev.00/> >> jdk changes: http://cr.openjdk.java.net/~sla/8076470/jdk/webrev.00/ >> <http://cr.openjdk.java.net/%7Esla/8076470/jdk/webrev.00/> >> hotspot changes: http://cr.openjdk.java.net/~sla/8076470/hotspot/webrev.00/ >> <http://cr.openjdk.java.net/%7Esla/8076470/hotspot/webrev.00/> >> >> Thanks, >> /Staffan >> >> >> >
