> On Aug 6, 2015, at 11:57 PM, Staffan Larsen <staffan.lar...@oracle.com> wrote: > > Please review the following changes to remove the hprof JVMTI agent. There > are changes in three different repositories. All tests that used the hprof > agent has been removed in previous changesets. > > Note: This does not remove the ability of the Hotspot VM to output heap dumps > in the hprof format. > > bug: https://bugs.openjdk.java.net/browse/JDK-8046661 > <https://bugs.openjdk.java.net/browse/JDK-8046661> > > top-level changes: http://cr.openjdk.java.net/~sla/8076470/root/webrev.00/ > <http://cr.openjdk.java.net/~sla/8076470/root/webrev.00/> > jdk changes: http://cr.openjdk.java.net/~sla/8076470/jdk/webrev.00/ > <http://cr.openjdk.java.net/~sla/8076470/jdk/webrev.00/> > hotspot changes: http://cr.openjdk.java.net/~sla/8076470/hotspot/webrev.00/ > <http://cr.openjdk.java.net/~sla/8076470/hotspot/webrev.00/> >
This patch looks fine to me. A minor comment: src/java.base/share/classes/sun/launcher/resources/launcher.properties - should this resource file be updated not to reference -agentlib:prof? I assume you have a JBS issue tracking the launcher man page and other documentation to be updated accordingly. Mandy
