Yes, naturally.
/Erik
On 2016-12-15 11:06, Thomas Stüfe wrote:
Hi Erik,
thank you! I would have needed a sponsor for the hotspot change in any
case, would sponsor this too?
Thomas
On Thu, Dec 15, 2016 at 10:00 AM, Erik Joelsson
<erik.joels...@oracle.com <mailto:erik.joels...@oracle.com>> wrote:
Hello Thomas,
Build changes look ok. Please note that the configure changes
requires synchronized changes in Oracle closed configure so will
need an Oracle sponsor to push. I assume this is intended for
jdk9/hs. I will be happy to push it for you once the change has
been cleared to go in.
/Erik
On 2016-12-15 07:43, Thomas Stüfe wrote:
Hi all,
please review this small change. It fixes the gtest build on
AIX and
enables it by default.
Note that even though this is a fix for AIX, a cast needed to
be added to
shared test coding. This is because xlC struggles with certain
template
expansions and I had to help it by providing an explicit cast.
Because linker options were changed as well, this
unfortunately this
spreads over two forest parts, so two webrevs were needed.
Issue: https://bugs.openjdk.java.net/browse/JDK-8171225
<https://bugs.openjdk.java.net/browse/JDK-8171225>
Webrevs:
(hotspot)
http://cr.openjdk.java.net/~stuefe/webrevs/8171225-aix-build-gtests/webrev.00/webrev/
<http://cr.openjdk.java.net/%7Estuefe/webrevs/8171225-aix-build-gtests/webrev.00/webrev/>
(top level)
http://cr.openjdk.java.net/~stuefe/webrevs/8171225-aix-build-gtests/toplevel-webrev.00/webrev/
<http://cr.openjdk.java.net/%7Estuefe/webrevs/8171225-aix-build-gtests/toplevel-webrev.00/webrev/>
Note that the toplevel change contains the newly generated
configure.sh. I
was not sure if that was needed, but it is included for
convenience.
Kind Regards, Thomas
