Hi Volker, Thank you for reviewing. I'll do the TOC issue this in a follow up change.
Kind Regards, Thomas On Thu, Dec 15, 2016 at 12:24 PM, Volker Simonis <volker.simo...@gmail.com> wrote: > Hi Thomas, > > can you please try to fix the TOC issues for the gtest build only. I > don't like that we have to build everything with '-qpic=large > -bbigtoc' just because of gtest. > > Isn't it possible to just set these parameters in > hotspot/make/lib/CompileGtest.gmk by using CFLAGS_aix/LDFALGS_aix? > > Thanks, > Volker > > > On Thu, Dec 15, 2016 at 7:43 AM, Thomas Stüfe <thomas.stu...@gmail.com> > wrote: > > Hi all, > > > > please review this small change. It fixes the gtest build on AIX and > enables > > it by default. > > > > Note that even though this is a fix for AIX, a cast needed to be added to > > shared test coding. This is because xlC struggles with certain template > > expansions and I had to help it by providing an explicit cast. > > > > Because linker options were changed as well, this unfortunately this > spreads > > over two forest parts, so two webrevs were needed. > > > > Issue: https://bugs.openjdk.java.net/browse/JDK-8171225 > > Webrevs: > > (hotspot) > > http://cr.openjdk.java.net/~stuefe/webrevs/8171225-aix- > build-gtests/webrev.00/webrev/ > > (top level) > > http://cr.openjdk.java.net/~stuefe/webrevs/8171225-aix- > build-gtests/toplevel-webrev.00/webrev/ > > > > Note that the toplevel change contains the newly generated configure.sh. > I > > was not sure if that was needed, but it is included for convenience. > > > > Kind Regards, Thomas >
