No, I have not pushed this fix yet. I was waiting for you to look into the CodeSectionProcessor issue. Do you want me to just push it?
Can you send me a diff of the change you want me to add? Bob. > On Aug 19, 2017, at 3:46 PM, Vladimir Kozlov <vladimir.koz...@oracle.com> > wrote: > > Bob, did you pushed it? > > If not yes, please fix .mx.graal/suite.py for unit tests Rickard added. They > have dependency on jdk.tools.jaotc.collect: > > test/compiler/aot/jdk.tools.jaotc.test/ > > They failed when I modified collect and other classes. We need to have > dependency on it in suite.py. > > Thanks, > Vladimir > > On 8/15/17 12:10 PM, Vladimir Kozlov wrote: >> On 8/15/17 11:55 AM, Bob Vandette wrote: >>> Please review these changes for JDK 10 that remove all dependencies on >>> libelf from the JDK >>> build system. >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-8186115 >>> >>> Webrev: >>> http://cr.openjdk.java.net/~bobv/8186115/ >> Good. >>> >>> Compiler team: Please check CodeSectionProcessor. Is the stepping through >>> all >>> foreign call still necessary? I only removed the comment. >> I will look. It could be the problem was not libelf but loader. >> Thanks, >> Vladimir >>> >>> Thanks, >>> Bob. >>>
