I took a quick peek at your failure handler. There's lots of necessarily non-portable stuff here, like invoking lsof, but I see much that is OS-dependent rather than VM-dependent, so I would still like to see some of it becoming (an optional) part of jtreg (which itself also comes with TimeoutHandlers). I've looked for TimeoutHandlers before, but only in the jtreg sources, not the openjdk sources. But my musing is not a comment on this CL; more a suggestion for jtreg-dev.
On Wed, Nov 29, 2017 at 12:21 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > > On 2017-11-28 23:03, Martin Buchholz wrote: > > Every jtreg run would like to have the most helpful failure handling > possible. Should some/all of this be pushed into jtreg itself instead of > the makefiles? > > As I understand things, jtreg has a kind of plugin structure. This is a > separate, specific plugin that leverages this functionality, and does some > kind of JVM-specific analysis in case of failure. I don't think that would > fit properly inside jtreg itself. > > /Magnus > > > On Mon, Nov 27, 2017 at 1:39 PM, Magnus Ihse Bursie < > magnus.ihse.bur...@oracle.com> wrote: > >> The jtreg failure handler needs to be used when running tests using the >> run-test framework. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8191933 >> WebRev: http://cr.openjdk.java.net/~ihse/JDK-8191933-use-failure-han >> dler-in-run-test/webrev.01 >> >> /Magnus >> >> > >
