Looks ok to me.
/Erik
On 2017-12-20 10:32, Volker Simonis wrote:
Hi Matthias,
the change looks good!
I can sponsor it once we get the approval.
Also forwarded to buil-dev for the minimal build change.
Thank you and best regards,
Volker
On Wed, Dec 20, 2017 at 9:50 AM, Baesken, Matthias
<matthias.baes...@sap.com> wrote:
Hello , Mark reported this issue on AIX with OpenJDK8 :
I'm getting an unsatisfied link error when using logstash on AIX but I suspect
the issue is with AIX or the JRE, the exception is:
java.lang.UnsatisfiedLinkError:
sun.management.OperatingSystemImpl.getProcessCpuLoad()D
getProcessCpuLoad at
sun/management/OperatingSystemImpl.java:-2
<init> at
org/logstash/instrument/monitors/ProcessMonitor.java:40
detect at
org/logstash/instrument/monitors/ProcessMonitor.java:79
generate at
org/logstash/instrument/reports/ProcessReport.java:15
this is the line in logstash:
this.cpuProcessPercent = scaleLoadToPercent(unixOsBean.getProcessCpuLoad());
https://github.com/elastic/logstash/blob/master/logstash-core/src/main/java/org/logstash/instrument/monitors/ProcessMonitor.java
Could anybody help steer me in the right direction?
This fix addresses the missing getSystemCpuLoad and getProcessCpuLoad on AIX
.
JDK8 is only affected , JDK9 and higher is not affected .
Could I get a review for this change ?
Change :
http://cr.openjdk.java.net/~mbaesken/webrevs/8193807/
Bug :
https://bugs.openjdk.java.net/browse/JDK-8193807
Thanks, Matthias
