Joe,

javac Source.java

  83
  84     /** 1.11 covers the to be determined language features that will be 
added in JDK 11. */
  85     JDK11("11"),
  86
  87     /** 12 covers the to be determined language features that will be 
added in JDK 12. */
  88     JDK12("12");

It would be nice if the comment for 11 was updated.

javac Profile.java

Nothing wrong in your edit, but maybe we should revisit/restrict this feature in due course.

javac PrintingProcessor

OK, but RFE: since this is part of javac, perhaps we could replace the annotation with an override of the getSupportedSourceVersion method, returning SourceVersion.latest.

jdeps Main

OK, but RFE: compute the list of releasesWithForRemoval, from 9 up to java.spec.version

javac test JavacTestingAbstractProcessor.java

OK, but RFE: perhaps we could replace the annotations with an
override of the getSupportedSourceVersion method, returning SourceVersion.latest.

-- Jon

On 06/26/2018 10:55 AM, joe darcy wrote:
On 6/26/2018 10:11 AM, Paul Sandoz wrote:
This generally looks good. Having it all consolidated helps a lot, and we are slowly chipping away at reducing this for each release.

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassFile.java
—

  118         V55(55, 0),   // JDK 11: constant dynamic
  119         V56(56, 0);   // JDK 12


We can add nestmates to the list of stuff in 11



Added ", nest mates" to the list for 11.

Thanks,

-Joe

Reply via email to