Hi Jon,
On 6/27/2018 12:50 PM, Jonathan Gibbons wrote:
Joe,
javac Source.java
83
84 /** 1.11 covers the to be determined language features that
will be added in JDK 11. */
85 JDK11("11"),
86
87 /** 12 covers the to be determined language features that
will be added in JDK 12. */
88 JDK12("12");
It would be nice if the comment for 11 was updated.
Will replace "to be determined" with "no explicit language changes".
javac Profile.java
Nothing wrong in your edit, but maybe we should revisit/restrict this
feature in due course.
Agreed; this would be a good item to review later in 12; filed
JDK-8205952: Review profile feature
javac PrintingProcessor
OK, but RFE: since this is part of javac, perhaps we could replace the
annotation with an
override of the getSupportedSourceVersion method, returning
SourceVersion.latest.
There are some reasons I'd prefer not to do that; I'll follow-up
separately to discuss my rationale.
jdeps Main
OK, but RFE: compute the list of releasesWithForRemoval, from 9 up to
java.spec.version
Created JDK-8205950: Have jdeprscan compute releasesWithForRemoval more
dynamically
javac test JavacTestingAbstractProcessor.java
OK, but RFE: perhaps we could replace the annotations with an
override of the getSupportedSourceVersion method, returning
SourceVersion.latest.
Filed JDK-8205951: Reduce size of edits needed to update
JavacTestingAbstractProcessor
Thanks for the review,
-Joe
