Hi Vladimir, Thanks for looking at my change.
> Thank you for fixing aot check in hotspot.m4 I guess this does no harm if aot is enabled, but I saw it on aix. > Add new method vmHasJFR() Fixed. New partial webrev: http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/02/ The other part is unchanged. Best regards, Goetz. > -----Original Message----- > From: Vladimir Kozlov <vladimir.koz...@oracle.com> > Sent: Thursday, July 19, 2018 7:22 PM > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; hotspot-dev > developers <hotspot-...@openjdk.java.net> > Cc: build-dev <build-dev@openjdk.java.net> > Subject: Re: 8207830: [aix] disable jfr in build and tests > > Tests changes are good. > > Thank you for fixing aot check in hotspot.m4 > > In VMProps.java I would suggest to follow code pattern from other > features. Add new method vmHasJFR() which returns "true" or "false" > instead of: > > map.put("vm.hasJFR", "" + WB.isJFRIncludedInVmBuild()); > > We may need such method to add other conditions in future. > > Thanks, > Vladimir > > On 7/19/18 12:17 AM, Lindenmaier, Goetz wrote: > > Hi, > > > > We didn't manage to port JFR to aix in the jdk11 time frame. > > Thus I would like to disable it in the build. > > As well, I would like to introduce @requires vm.hasJFR which > > will disable the tests on aix, and also on linuxsparcv9 and zero. > > > > Two webrevs for better readability: > > This contains the functional changes > > http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01/ > > This contains adding @requires. > > http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-test/ > > http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-tests/ > > > The only one not straight forward is > runtime/appcds/sharedStrings/FlagCombo.java > > > > Best regards, > > Goetz. > >
