Thanks Erik!
Best regards,
Goetz.
> -----Original Message-----
> From: Erik Joelsson <erik.joels...@oracle.com>
> Sent: Donnerstag, 19. Juli 2018 19:33
> To: Vladimir Kozlov <vladimir.koz...@oracle.com>; Lindenmaier, Goetz
> <goetz.lindenma...@sap.com>; hotspot-dev developers <hotspot-
> d...@openjdk.java.net>
> Cc: build-dev <build-dev@openjdk.java.net>
> Subject: Re: 8207830: [aix] disable jfr in build and tests
>
> Build changes look good.
>
> /Erik
>
>
> On 2018-07-19 10:22, Vladimir Kozlov wrote:
> > Tests changes are good.
> >
> > Thank you for fixing aot check in hotspot.m4
> >
> > In VMProps.java I would suggest to follow code pattern from other
> > features. Add new method vmHasJFR() which returns "true" or "false"
> > instead of:
> >
> > map.put("vm.hasJFR", "" + WB.isJFRIncludedInVmBuild());
> >
> > We may need such method to add other conditions in future.
> >
> > Thanks,
> > Vladimir
> >
> > On 7/19/18 12:17 AM, Lindenmaier, Goetz wrote:
> >> Hi,
> >>
> >> We didn't manage to port JFR to aix in the jdk11 time frame.
> >> Thus I would like to disable it in the build.
> >> As well, I would like to introduce @requires vm.hasJFR which
> >> will disable the tests on aix, and also on linuxsparcv9 and zero.
> >>
> >> Two webrevs for better readability:
> >> This contains the functional changes
> >> http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01/
> >> This contains adding @requires.
> >> http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-test/
> >
> > http://cr.openjdk.java.net/~goetz/wr18/8207830-aixDisableJFR/01-tests/
> >
> >> The only one not straight forward is
> >> runtime/appcds/sharedStrings/FlagCombo.java
> >>
> >> Best regards,
> >> Goetz.
> >>
