Hi Aleksey, Thanks for your review. Please see new patch at http://cr.openjdk.java.net/~njian/8211207/webrev.01/ I've added line breaks after "default:" and restored a missing break in switch-case.
Could you help push this new patch if no other issues? -- Thanks, Pengfei > -----Original Message----- > > On 09/27/2018 09:10 AM, Pengfei Li (Arm Technology China) wrote: > > Please help review this patch that fixed these warnings in AArch64 backend. > > webrev: http://cr.openjdk.java.net/~njian/8211207/webrev.00/ > > Please break the line after "default:" to match the style in > c1_LIRGenerator_aarch64.cpp here: > > 795 default: break; > 796 } > 797 } > 798 default: break; > 799 } > > Otherwise looks good and trivial. > > Thanks, > -Aleksey