On 09/27/2018 10:21 AM, Andrew Haley wrote:
> On 09/27/2018 08:22 AM, Aleksey Shipilev wrote:
>> Otherwise looks good and trivial.
>
> No, it is neither good nor trivial:some of those should be
> ShouldNotReachHere().
> I'll post a webrev later.
Okay, let's see it.
I was mostly concerned with having the same control flow as before, did I miss
some change that is
actually non-trivial? On the second read, this change in
c1_LIRAssembler_aarch64.cpp looks
suspicious, as it elevates ShouldNotReachHere to default case, rather than
letting default thing
fall-through?
break;
+ default:
ShouldNotReachHere();
}
-Aleksey
