Hi Michal,
does not yet work for me. I get cygpath Usage output:
$ bash ./bin/idea.sh
Usage: cygpath (-d|-m|-u|-w|-t TYPE) [-f FILE] [OPTION]... NAME...
cygpath [-c HANDLE]
cygpath [-ADHOPSW]
cygpath [-F ID]
Convert Unix and Windows format paths, or output system path information
...
Cheers, Thomas
On Fri, Nov 9, 2018 at 6:09 PM Michal Vala <mv...@redhat.com> wrote:
>
> You're right, sorry. Updated webrev:
> http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8213591/webrev.01/
>
> On 11/9/18 5:42 PM, Erik Joelsson wrote:
> > Hello Michal,
> >
> > It looks like the "dirname" calls are omitted in the cygpath case, so
> > BUILD_DIR
> > ends up pointing to the spec file instead of the directory the file is in.
> >
> > /Erik
> >
> >
> > On 2018-11-09 05:58, Michal Vala wrote:
> >> Hi,
> >>
> >> I've looked into this. Please review the patch:
> >> http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8213591/webrev.00/
> >>
> >> On 11/9/18 9:29 AM, Baesken, Matthias wrote:
> >>> Hello , I opened
> >>>
> >>> 8213591 : running bin/idea.sh in Cygwin: generated project cannot be
> >>> imported
> >>>
> >>> https://bugs.openjdk.java.net/browse/JDK-8213591
> >>>
> >>> for the reported issue .
> >>>
> >>> Best regards, Matthias
> >>>
> >>>> -----Original Message-----
> >>>> From: Erik Joelsson <erik.joels...@oracle.com>
> >>>> Sent: Donnerstag, 8. November 2018 18:05
> >>>> To: Baesken, Matthias <matthias.baes...@sap.com>; Chris Hegarty
> >>>> <chris.hega...@oracle.com>; 'build-dev@openjdk.java.net' <build-
> >>>> d...@openjdk.java.net>; maurizio.cimadam...@oracle.com
> >>>> Subject: Re: bin/idea.sh and Cygwin
> >>>>
> >>>> A patch fixing idea.sh so that it works on Windows would certainly be
> >>>> welcome.
> >>>>
> >>>> /Erik
> >>>>
> >>>>
> >>>> On 2018-11-08 05:12, Baesken, Matthias wrote:
> >>>>> Hi Chris , thanks for the info .
> >>>>>
> >>>>> However I found out that replacing the /cygdrive/C/ with C:/ in the
> >>>> top-level xml/iml files in the ".idea" - folder
> >>>>> makes IntelliJ happy, I could then open the project
> >>>>> successfully
> >>>>> from
> >>>> IntelliJ .
> >>>>>
> >>>>> So I guess a couple of "cygpath -aw" -calls at the right places
> >>>>> in
> >>>>> the
> >>>> project generation might fix the idea.sh based project file
> >>>> generation on
> >>>> Cygwin (without postprocessing).
> >>>>> Any comments on this ?
> >>>>>
> >>>>> Or is there another way to get .idea/-files that open "out of the
> >>>>> box" ?
> >>>>>
> >>>>>
> >>>>> Best regards, Matthias
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>> -----Original Message-----
> >>>>>> From: Chris Hegarty <chris.hega...@oracle.com>
> >>>>>> Sent: Donnerstag, 8. November 2018 12:52
> >>>>>> To: Baesken, Matthias <matthias.baes...@sap.com>; 'build-
> >>>>>> d...@openjdk.java.net' <build-dev@openjdk.java.net>;
> >>>>>> maurizio.cimadam...@oracle.com
> >>>>>> Subject: Re: bin/idea.sh and Cygwin
> >>>>>>
> >>>>>> Matthias,
> >>>>>>
> >>>>>> On 08/11/18 11:45, Baesken, Matthias wrote:
> >>>>>>> Hello, I tried to use bin/idea.sh with Cygwin to generate project
> >>>>>>> files
> >>>> for
> >>>>>> IDEA IntelliJ Community .
> >>>>>>> The project file generation seems to work and outputs the .idea -
> >>>> folder
> >>>>>> with lots of xml files in it .
> >>>>>>> However , when opening the project from IDEA, it fails with a
> >>>> message :
> >>>>>>>
> >>>>>>> VCS root configuration problems -
> >>>>>>>
> >>>>>>> The directory \cygdrive\C\hg\open\jdk\jdk6 is registered as a hg4idea
> >>>> root
> >>>>>> but no hg4idea repositories were found there .
> >>>>>>> C.\hg\open\jdk\jdk6
> >>>>>>>
> >>>>>>>
> >>>>>>> Could it be that the Cygwin-paths in the generated xml-files confuse
> >>>> the
> >>>>>> IDEA intelliJ IDE ?
> >>>>>>
> >>>>>> Certainly looks like it.
> >>>>>>
> >>>>>>> Has anybody ever used it successfully with Cygwin/ Windows ?
> >>>>>>> ( or with some other UNIX shell/toolset for Windows) ?
> >>>>>> I have not tried. I use it successfully on macOS and Linux.
> >>>>>>
> >>>>>> -Chris.
> >>>
> >>
> >
>
> --
> Michal Vala
> OpenJDK QE
> Red Hat Czech
