On 19/03/2019 15:09, Martin Buchholz wrote: > Probably it's because glibc deprecated readdir, and we don't have > --disable-warnings-as-errors by default? > > (I think warnings should not be errors except as opt-in by openjdk > developers/maintainers) > > On Tue, Mar 19, 2019 at 7:47 AM Andrew Haley <a...@redhat.com> wrote: > >> On 3/19/19 12:25 PM, Jie Fu wrote: >>> To fix build failures caused by deprecated-declarations warnings, can we >>> make this change to jdk8u? >> >> This is very GCC-version dependent. We really should probe at configure >> time for >> these options. >> >> -- >> Andrew Haley >> Java Platform Lead Engineer >> Red Hat UK Ltd. <https://www.redhat.com> >> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 >>
If this is because of readdir_r, then that's on my radar to backport once we've branched for 8u212 (it needs time to soak, so I'm aiming for 8u222). I've prefer we fixed this rather than disabling warnings unnecessarily. -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew
