On 3/20/19 3:53 PM, Andrew John Hughes wrote: > On 19/03/2019 15:09, Martin Buchholz wrote: >> Probably it's because glibc deprecated readdir, and we don't have >> --disable-warnings-as-errors by default? >> >> (I think warnings should not be errors except as opt-in by openjdk >> developers/maintainers) > I agree
I'm pretty sure that -Wall should never be used with -Werror, because -Wall is a grab bag of unconnected warnings. The official doc is "all the warnings about constructions that some users consider questionable, and that are easy to avoid (or modify to prevent the warning)". So, I think that warnings-as-errors makes sense, but not in conjunction with -Wall. I guess no-one wants to start the bikeshed discussion about which warnings should be on, though. -- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
