Hi! Any more thoughts on this? It would be nice to get this reviewed :)
Thanks, Severin On Thu, 2019-05-23 at 11:53 +0200, Severin Gehwolf wrote: > Hi Andrew, > > On Thu, 2019-05-23 at 09:34 +0100, Andrew Dinn wrote: > > Hi Severin, > > > > On 22/05/2019 17:34, Severin Gehwolf wrote: > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8222737 > > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/ > > > (includes changes to top/hotspot/jdk/langtools repos) > > > > > > Example excerpt from a run: > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/example_output.txt > > > > > > Thoughts? > > Unfortunately, my makefile fu is too limited to provide a reliable > > review of the patch (I'm mostly just surprised it took so few changes to > > achieve). However, I can still wholeheartedly applaud this endeavour and > > its present outcome. > > :) Great. > > > As you say tuning the test group can be done over time as a follow-up. > > The important thing is to quickly place devs in a position to easily > > check that fixes have no unintended side-effects. Very nice! > > Thanks for looking this over! > > Cheers, > Severin
