On 22/05/2019 17:34, Severin Gehwolf wrote:
> Hi,
>
> Could I please get reviews for this minimal implementation of a tier1-
> like test set for JDK 8u? The implementation is rather barebones as I
> don't think it's worth rewriting the build system just for a command
> that runs a certain set of tests across a select set of repositories.
> I've re-used existing work in Makefiles as much as possible. After this
> patch one can do:
>
> $ make test TEST="tier1"
>
> Inspiration came from JDK 11u's tier1. As for prior art to this, I've
> only found "make test" to be working for JDK 8u from the top level.
> Yet, it doesn't run any hotspot tests, exits with a zero code on test
> failures and doesn't present a summary at the end. Overall not a nice
> developer experience.
>
> This patch makes it easier for a developers tests. It presents a
> summary at the end, returns non-zero on test failures so this can get
> used in CI and runs hotspot tests.
>
> As a follow-on we can work on fixing/excluding tests so that we always
> have a passing set of tests for developers to run before a checkin.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222737
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/
> (includes changes to top/hotspot/jdk/langtools repos)
>
> Example excerpt from a run:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/example_output.txt
>
> Thoughts?
>
> Thanks,
> Severin
>
Is there a reason for creating new tier definitions here rather than
backporting the existing ones?
https://bugs.openjdk.java.net/browse/JDK-8075543
The subtasks also cover nashorn & jaxp which are missed here. jaxp would
need JDK-8065673, JDK-8051540 and friends to convert its tests to jtreg.
--
Andrew :)
Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew
