Hi Andrew, On Fri, 2019-07-26 at 14:46 +0100, Andrew John Hughes wrote: > On 25/07/2019 16:02, Severin Gehwolf wrote: > > snip... > > > > Done now. I've added fix-request comments/labels to the above bugs and > > > rebased on top of them. New jdk changeset: > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/04/jdk/webrev/ > > > > > > Test groups definition is the JDK 9 set plus :jdk_jdi test set (part of > > > JDK-8198551 in later JDKs). This seems a reasonable test set. Modulo > > > added intrinsics testing only relevant for 9+, see JDK-8132855 and JDK- > > > 8132854. > > > > > > OK to push? > > > > Any more thoughts? > > > > Thanks, > > Severin > > > > This webrev lists three different bug IDs.
It beats me why webrev lists other bugs. The other two, 8075573 and 8075544, were clean backports and were pushed after jdk8u-fix-yes got added. > What exactly is being pushed > here? The following 4 patches: jdk: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/04/jdk/webrev/ hotspot: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/03/hotspot/webrev/ langtools: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/03/langtools/webrev/ top: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8222737/02/top/webrev/ Each of them has a reference to a plain patch file if you prefer to review that. Thanks, Severin
