Hi Andrew! On 2/16/20 12:07 PM, Andrew Haley wrote: > On 2/15/20 6:33 PM, John Paul Adrian Glaubitz wrote: >> >> Here is another approach for fixing 8238281 [1]. Please review. >> >>> [1] http://cr.openjdk.java.net/~glaubitz/8239001/webrev.01/ > > Can you give us a bit more explanation about why 8238281 broke linux-sparc, > and why your proposal is valid? This doesn't look valid to me:
The problem is that i[j] is a non-const expression which is not allowed when using offsetof(). I have included the GCC error message in the bug report [1]. > (((RegistersForDebugging*)16)->f[0]) > This basically just calculates the offset within the array f with the offset j, hence the factor j. I have to admit though that I haven't fully understood Kim's non-odr-used approach yet. Thanks, Adrian > [1] https://bugs.openjdk.java.net/browse/JDK-8239001 -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
