On Tue, 22 Sep 2020 13:36:58 GMT, Robin Westberg <rwestb...@openjdk.org> wrote:
>> We don't have a good source currently no, but something to keep in mind.
>> Ideally we would want to create a common
>> source for both jib-profiles.js and the gitactions to read from. I would
>> prefer something that can be read both as a
>> properties file and sourced as a shell script, much like the version-numbers
>> file currently is. That could be done as a
>> separate change though.
>
> Sure, should not be that hard to parse something similar. The GitHub actions
> will probably need it in JSON format at
> some point, but nothing a little `sed -e '1i {' -e 's/#.*//g' -e 's/"//g' -e
> 's/(.*)=(.*)/"\1": "\2",/g' -e
> '$s/,\s{0,}$/}/'` won't solve. Any suggestion for the location and name of
> such a file? I'm thinking it would contain
> entries like this: BOOT_JDK_VERSION="14.0.2" JTREG_VERSION="jtreg5.1-b01"
> GTEST_VERSION="release-1.8.1"
> LINUX_X64_BOOT_JDK_FILENAME="openjdk-14.0.2_linux-x64_bin.tar.gz"
> LINUX_X64_BOOT_JDK_URL="https://download.java.net/java/GA/jdk14.0.2/205943a0976c4ed48cb16f1043c5c647/12/GPL/openjdk-14.0.2_linux-x64_bin.tar.gz";
> LINUX_X64_BOOT_JDK_SHA256="91310200f072045dc6cef2c8c23e7e6387b37c46e9de49623ce0fa461a24623d"
The other primary consumer of this is make/conf/jib-profiles.js. The make/conf
dir would make sense to me.
The challenge here is creating a set of variables that are suitable enough for
both config files to consume. For
BootJDK, we never bothered with bumping the version for updates, and I very
much doubt we will do that in the future
for github actions, so a plain major version 14, and soon 15, would be
preferred from my point of view. This is however
not enough for jib-profiles.js (yet) so we can't really share bootjdk config
for now anyway. For jtreg, we specify 5.1
and b01 as two separate metadata values. For gtest we specify the version as
1.8.1.
-------------
PR: https://git.openjdk.java.net/jdk/pull/284
