On Wed, 23 Sep 2020 17:55:23 GMT, Robin Westberg <rwestb...@openjdk.org> wrote:
>> The version-numbers file (which is also a shared properties style file) is >> not using quotes for values, which is fine >> as long as there are no spaces. I believe if you read it as a properties >> file, you need to strip the quotes if you have >> them. I prefer if version-numbers and test-dependencies using the same >> format. Otherwise this looks good to me! > > Sounds reasonable, didn't notice that discrepancy! Fixed in the latest commit. After some feedback on the jdk-dev mailing list (thanks @jaikiran!) I took a second look at removing artifacts that are only created for passing between the build and test steps. Turns out that there is an API for this (it's still in preview, but seems to work fine) that can be used for this. When this API is finalized we can update that part, but it's not a deal-breaker even if it should change, as the test runs will still complete successfully. With this API available, it's also possible to publish a single artifact containing all test results, regardless of outcome. ------------- PR: https://git.openjdk.java.net/jdk/pull/284
