On Fri, 25 Sep 2020 21:45:13 GMT, Ioi Lam <ik...@openjdk.org> wrote:

>> Yumin Qi has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8247536: Support for pre-generated java.lang.invoke classes in CDS static 
>> archive
>
> test/hotspot/jtreg/runtime/cds/appcds/DumpClassListWithLF.java line 32:
> 
>> 30:  * @library /test/lib /test/hotspot/jtreg/runtime/cds/appcds
>> 31:  * @compile ClassListFormatBase.java test-classes/Hello.java
>> 32:  * @run driver DumpClassListWithLF
> 
> The `@compile` line can be removed to speed up the test execution. You can 
> add this:
> 
> @library /test/lib /test/hotspot/jtreg/runtime/cds/appcds/test-classes
> 
> and also change the code below
> 
>             appJar, classlist(
> -                "Hello",
> +                Hello.class.getName(),
> 
> (There's no need for `/test/hotspot/jtreg/runtime/cds/appcds` in `@library` 
> because that's the current directory of
> this test).

I tried using @library and passed local tests, but it failed mach5 for 
complaining no file Hello.class found from path.

-------------

PR: https://git.openjdk.java.net/jdk/pull/193

Reply via email to