> This patch is reorganized after 8252725, which is separated from this patch 
> to refactor jlink glugin code. The previous
> webrev with hg can be found at: 
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 
> integrated, the
> regeneration of holder classes is simply to call the new added 
> GenerateJLIClassesHelper.cdsGenerateHolderClasses
> function.  Tests: tier1-4

Yumin Qi has updated the pull request incrementally with one additional commit 
since the last revision:

  Move the check work to java, restore code in VM. Modified test code according 
to the changes. The invoke name
  verififcation is not implemented since not all the holder class are 
processed, not all the functions of processed
  holder classes are added. For holder class with DirectMethodHandle in its 
name, only the name in the
  DMH_METHOD_TYPE_MAP keyset is added, ithe line with other names just gets 
skipped silently. This makes the verification
  on invoke names difficul, a name not in the keyset should not fail the test. 
Also add a boolean to
  cdsGenerateHolderClasses to indicate call path.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/193/files
  - new: https://git.openjdk.java.net/jdk/pull/193/files/9b0f523b..125112b3

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=193&range=07
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=193&range=06-07

  Stats: 87 lines in 3 files changed: 70 ins; 10 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/193.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/193/head:pull/193

PR: https://git.openjdk.java.net/jdk/pull/193

Reply via email to