On Mon, 23 Nov 2020 09:35:40 GMT, Bernhard Urban-Forster <bur...@openjdk.org> wrote:
> This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to be downloaded from https://jdk.java.net/16/ and used for that, but then I > saw how @shipiliv attempted it for the linux cross-compilation builds in > https://github.com/openjdk/jdk/pull/1147. That is using the JDK image > produced by the x64 variant. This however add more stress to the "critical > path", as now two more jobs depend on the x64 build first. > > Let's see how it works out in the long-run. A Windows+AArch64 build takes > 40-50min. I think you need to wait for #1350, and then reconcile this patch with that refactoring. .github/workflows/submit.yml line 1250: > 1248: flavor: > 1249: - build release > 1250: - build debug Other foreign arches build only `debug`, thus optimizing the workflow time, drop `release` here? .github/workflows/submit.yml line 1367: > 1365: git apply p.patch > 1366: working-directory: jdk > 1367: shell: bash This should be in the mainline repo instead. Yes, the absence of this patch blocks this PR, but getting that patch into the mainline first is the right thing to do. .github/workflows/submit.yml line 2021: > 2019: - linux_x64_test > 2020: - linux_x86_test > 2021: - windows_aarch64_build This should move to other `_build` needs, for clarity. ------------- Changes requested by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1379
