On Mon, 23 Nov 2020 11:59:53 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

>> This adds the cross-compiled build only, as no Windows+Arm64 machines are 
>> available on GitHub Action that we could use to run the tests.
>> 
>> Due to cross-compilation a build JDK is required. Initially I added EA 
>> builds to be downloaded from https://jdk.java.net/16/ and used for that, but 
>> then I saw how @shipiliv attempted it for the linux cross-compilation builds 
>> in https://github.com/openjdk/jdk/pull/1147.  That is using the JDK image 
>> produced by the x64 variant. This however add more stress to the "critical 
>> path", as now two more jobs depend on the x64 build first.
>> 
>> Let's see how it works out in the long-run. A Windows+AArch64 build takes 
>> 40-50min.
>
> .github/workflows/submit.yml line 1367:
> 
>> 1365:           git apply p.patch
>> 1366:         working-directory: jdk
>> 1367:         shell: bash
> 
> This should be in the mainline repo instead. Yes, the absence of this patch 
> blocks this PR, but getting that patch into the mainline first is the right 
> thing to do.

I agree. We should not have a build action that requires a patch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1379

Reply via email to