On Fri, 8 Jan 2021 06:03:46 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:

>> make/scripts/fixpath.sh line 152:
>> 
>>> 150:     # If it fails, try again with an added .exe (needed on WSL)
>>> 151:     if [[ $? -ne 0 ]]; then
>>> 152:       path="$path.exe"
>> 
>> This seems to conflict with the logic starting at line #173 below.
>
> I pushed to new commit to save original `$path` and restore it later if the 
> path not found.
> Could you review again?

Sorry but I'm really not following exactly what the problem is and thus the 
solution. How does setting path affect the running of PATHTOOL? Does the 
problem indicate we should be using winpath rather than path somewhere?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1889

Reply via email to