On Fri, 8 Jan 2021 06:23:35 GMT, David Holmes <dhol...@openjdk.org> wrote:

>> I pushed to new commit to save original `$path` and restore it later if the 
>> path not found.
>> Could you review again?
>
> Sorry but I'm really not following exactly what the problem is and thus the 
> solution. How does setting path affect the running of PATHTOOL? Does the 
> problem indicate we should be using winpath rather than path somewhere?

In this case `$PATHTOOL` points `wslpath`, and it tries to convert 
`$JAVA_HOME/bin/java` to Windows path. However `java` on Windows is `java.exe`, 
so we need to convert it.

Currently `fixpath.sh` adds `.exe` if `wslpath` fails, then attempt to do it 
again, but `$path` still lost extension ( `.exe`). So `configure` will fail on 
WSL because `java.exe` cannot be find.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1889

Reply via email to