On Mon, 25 Jan 2021 13:19:31 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> make/conf/module-loader-map.conf line 100: >> >>> 98: # Hook to include the corresponding custom file, if present. >>> 99: $(eval $(call IncludeCustomExtension, conf/module-loader-map.conf)) >>> 100: >> >> Using IncludeCustomExtension is a good idea, but you should to this where >> module-loader-map.conf is included in common/Modules.gmk, not here. The >> `*.conf` files are supposed to be formatted as simple configuration files, >> and not include special make commands. > > @magicus Is there an ordering issue in common/Modules.gmk? It also invokes > IncludeCustomExtension but this is done before it includes the conf file. @AlanBateman Yes, that's what JDK-8258411 inadvertently changed and I am fixing. I am going to now move the common/Modules.gmk IncludeCustomExtension after the module-loader-map.conf include. ------------- PR: https://git.openjdk.java.net/jdk/pull/2219
