On Mon, 25 Jan 2021 13:45:23 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> The previous behavior provided the ability to "extend" the upstream MODULE >> lists, ie.just add OpenJ9 modules to the base module lists, see: >> https://github.com/ibmruntimes/openj9-openjdk-jdk/blob/01e13c398721628540babac94ac8663be716c0a8/closed/custom/common/Modules.gmk#L21 >> >> The present >> https://github.com/openjdk/jdk/blob/master/make/conf/module-loader-map.conf >> will simply over-write whatever is set in the BOOT_MODULES list. >> >> What I am now going to do is move the IncludeCustomExtension after the >> module-loader-map.conf inclusion. >> The other alternative would be to change module-loader-map.conf so it >> appended to any existing BOOT_MODULES variable, but I think you suggested >> that file is a straight conf file? >> >> @magicus thoughts? > > Note, it was the change from "appending" to BOOT_MODULES to just "assigning" > that broke the existing behaviour with the JDK-8258411 change. @andrew-m-leonard (Seems I can't get github to tag you???) That sounds good. I think you could move the IncludeCustomExtension to after all *.conf files, to future-proof it and to make it a bit more consistent -- "first include conf files, then adjust them in custom extensions". ------------- PR: https://git.openjdk.java.net/jdk/pull/2219
