On Tue, 30 Mar 2021 12:29:49 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> I'm a bit surprised at this myself. If it is needed, I will accept this >> patch, but then I think we need to fix that properly and submit a follow-up >> patch. >> >> I also note that on macos-x64 we add `--enable-compatible-cds-alignment` as >> well. I wonder if we should not do that here as well..? (Although I must >> admit I did not fully understand when and how the CDS alignment rules >> applied.) > > I don't think we need to set SETFILE anymore. This used to be needed because > the SetFile binary in older Xcode versions was 32 bit and Catalina no longer > supports 32 bit apps. This should definitely not be a problem on aarch64. I don't think we need the compatible cds alignment here. This was added for x64 mainly to make it run correctly in rosetta IIRC. Macos aarch64 binaries will most likely run well in their native environment without this. >> This seems to be used at line 1133 where 11.3.1 is hard-coded for x64. So I >> guess it works but I'm not very fond of this solution. @vidmik Why don't you >> put both x64 and aarch64 revisions here? > > As I understand it, the intention is to bump the Xcode version for x64 as > well, though I must say I would prefer that change to go in separately. To answer Magnus, on line 1133, we define a different dependency, called "lldb". That dependency is an older devkit which only purpose is to provide lldb for the failure handler when running tests. We need this because we are still running tests on Macos < 10.15, but the new devkit requires 10.15. ------------- PR: https://git.openjdk.java.net/jdk/pull/3258
