On Tue, 30 Mar 2021 14:42:22 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> To answer Magnus, on line 1133, we define a different dependency, called >> "lldb". That dependency is an older devkit which only purpose is to provide >> lldb for the failure handler when running tests. We need this because we are >> still running tests on Macos < 10.15, but the new devkit requires 10.15. > > I agree that it would be ideal for the update to Xcode 12.x to be done > separately. Is there a JBS issue filed for this update? Alternatively, you > could use `/issue add nnnnnnn` to add that JBS issue to this PR. Thank you for catching the accidental Xcode update for macosx-x64. It was not my intention to include that as part of this change. That said, right now it's looking highly likely that we will have bumped it for macosx-x64 before this PR is ready for integration anyway. Therefore, for now I will keep it as-is, but integration of this PR is effectively blocked until it has been resolved - either by making it conditional on the architecture or by the switch to "Xcode12.4+1.0" for macosx-x64 making it into mainline. As Erik mentions, the new "lldb" dependency is needed to support running the failure handler+lldb when testing on older macOS versions which do not support Xcode 12.4. Assuming the switch to Xcode 12.4 as devkit for macosx-x64 makes it into mainline I believe the logic is correct. ------------- PR: https://git.openjdk.java.net/jdk/pull/3258
