On Mon, 7 Jun 2021 14:53:55 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8263468: automate build integration > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties > line 268: > >> 266: doclet.help.new.body=\ >> 267: The {0} page lists APIs that have been added in recent releases. \ >> 268: The content of this page is based on information provided by >> Javadoc @since tags. > > Either change to "JavaDoc" or (preferably?) just delete this word, or even > the sentence. > > Is there any interaction with `-nosince`? Should there be? I removed the second sentence. There is no interaction with `-nosince`. I one point I thought `-nosince` should disable this feature, but actually both features are just different ways of displaying the information stored in `@since` tags that don't depend on each other. > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Extern.java > line 337: > >> 335: */ >> 336: public int getSourceVersionNumber() { >> 337: return configuration.docEnv.getSourceVersion().ordinal(); > > As a general comment, I believe Joe does not encourage use of `ordinal` I undid this change as it's not really part of the feature. ------------- PR: https://git.openjdk.java.net/jdk/pull/4209