On Mon, 7 Jun 2021 19:48:39 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> This adds a new kind of summary list for new API added in specific releases, >> and adds information to the deprecated API list about elements that were >> deprecated in the given releases. >> >> The changes to the code are relatively minor thanks to the existing >> infrastructure for summary list pages, which was extended by adding the >> `getTableCaption` and `addTableTabs` methods to `SummaryListWriter.java` in >> order to generate tabbed tables. >> >> One important area that needs to be reviewed is the addition of resources in >> `standard.properties`. A relatively big share of discussion and effort went >> into shaping the UI messages. >> >> The build system change adds options to generate API changes for all >> releases after JDK 11, with "New API since JDK 11" as page title for the new >> API page. I uploaded the generated documentation here: >> >> http://cr.openjdk.java.net/~hannesw/8263468/api-pr.00/new-list.html >> http://cr.openjdk.java.net/~hannesw/8263468/api-pr.00/deprecated-list.html > > Hannes Wallnöfer has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8263468: review comments One future suggestion. src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties line 113: > 111: deprecated elements, regardless of the releases in which they were > deprecated. \ > 112: Each of the other tabs "Deprecated in ..." indicates the elements > deprecated \ > 113: in a specific release.) This is OK for now, but a noreg-doc follow-up might be to improve the punctuation in this text, possibly after consulting with docs folk. It's the use of the quoted strings that seems weird, without any commas or parentheses too set them off. On the other hand, I realize we sometimes go for brevity in places like this. ------------- Marked as reviewed by jjg (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4209
