On Wed, 20 Oct 2021 14:30:04 GMT, Pavel Rappo <pra...@openjdk.org> wrote:

>> Yes, they are localized. Good question, I do believe tests are run with 
>> fixed en/US locale, but I'm not absolutely sure.
>
> I've traced the execution of a local jtreg run with a debugger and examined 
> the respective `jtr` file. Here is what I saw. The locale that the javadoc 
> under test uses is that of returned by java.util.Locale.getDefault(). This 
> happens because neither of the three pieces -- jtreg, JavadocTester, or 
> TestSnippetTag -- passes `-locale` to javadoc.
> 
> Now I begin to wonder: how come we don't see failures on CI builds? Are we 
> lucky and all the machines on which javadoc tests run use variants of English 
> locale? Do we not have other tests where we hard-code English string 
> variants? Is there something that I don't see?

You don't have to do anything about locales in this PR; this part is fine as it 
is. I filed a bug, JDK-8275727, to address this issue at mass. It looks like 
almost half of javadoc tests have a similar issue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6011

Reply via email to