On Thu, 2 Dec 2021 14:55:14 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> This is basically Andrew's old patch that was backed out, with a single > change: I'm using ZipFile instead of ZipInputStream to read in the original > zip. The latter is not capable of reading the extended attributes that > contain the unix permissions. (Why this is so, is not fully clear to me. > What's worse, it's by no means clear from the documentation. We should > probably file a follow-up bug to improve the Javadoc for ZipInputStream, > warning the users to stay away if they can.) > > I have also added the possibility to opt-out of reproducible building by an > argument to SetupZipArchive. This is used in the closed Oracle part of the > build, where we create some temporary zip files that are later discarded, and > not part of the deliverables. This saves us some unnecessary overhead. Marked as reviewed by erikj (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/6673
