On Thu, 2 Dec 2021 14:55:14 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> This is basically Andrew's old patch that was backed out, with a single > change: I'm using ZipFile instead of ZipInputStream to read in the original > zip. The latter is not capable of reading the extended attributes that > contain the unix permissions. (Why this is so, is not fully clear to me. > What's worse, it's by no means clear from the documentation. We should > probably file a follow-up bug to improve the Javadoc for ZipInputStream, > warning the users to stay away if they can.) > > I have also added the possibility to opt-out of reproducible building by an > argument to SetupZipArchive. This is used in the closed Oracle part of the > build, where we create some temporary zip files that are later discarded, and > not part of the deliverables. This saves us some unnecessary overhead. This pull request has now been integrated. Changeset: c93552c8 Author: Magnus Ihse Bursie <i...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/c93552c8bbcdabb6219327d67409bf63432f49d8 Stats: 262 lines in 4 files changed: 255 ins; 0 del; 7 mod 8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible" Co-authored-by: Andrew Leonard <aleon...@openjdk.org> Co-authored-by: Magnus Ihse Bursie <i...@openjdk.org> Reviewed-by: erikj ------------- PR: https://git.openjdk.java.net/jdk/pull/6673
