On Wed, 2 Mar 2022 08:27:19 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:

> > This also removes support for the legacy cross compilation flags as well.
> 
> Hi,
> 
> without reading through building.md and your patch, which legacy flags are 
> would be removed by this?
> 
> Thanks, Thomas

Specifically the flags that are checked if openjdk-target is specified, in 
make/autoconf/configure (Essentially just passing --build, --host and --target 
directly to configure, something which is largely discouraged within the JDK):

if test "x$conf_legacy_crosscompile" != "x"; then
  if test "x$conf_openjdk_target" != "x"; then
    echo "Error: Specifying --openjdk-target together with autoconf"
    echo "legacy cross-compilation flags is not supported."
    echo "You specified: --openjdk-target=$conf_openjdk_target and 
$conf_legacy_crosscompile."
    echo "The recommended use is just --openjdk-target."
    exit 1
  else
    echo "Warning: You are using legacy autoconf cross-compilation flags."
    echo "It is recommended that you use --openjdk-target instead."
    echo ""
  fi
fi




> Oh, and please describe whatever you do in the JBS issue. It's completely 
> blank. It would be nice if it contained a description of what you do, at 
> least as good as the PR text. Thank you!

Will do, thanks for the heads up!

-------------

PR: https://git.openjdk.java.net/jdk/pull/7656

Reply via email to