On Thu, 12 May 2022 01:27:30 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> * src/hotspot/share/oops/array.hpp
>> *
>> src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp
>>
>> In member function 'void Array<T>::at_put(int, const T&) [with T = unsigned
>> char]',
>> inlined from 'void ConstantPool::tag_at_put(int, jbyte)' at
>> /home/ysuenaga/github-forked/jdk/src/hotspot/share/oops/constantPool.hpp:126:64,
>> inlined from 'void ConstantPool::method_at_put(int, int, int)' at
>> /home/ysuenaga/github-forked/jdk/src/hotspot/share/oops/constantPool.hpp:380:15,
>> inlined from 'ConstantPool*
>> BytecodeConstantPool::create_constant_pool(JavaThread*) const' at
>> /home/ysuenaga/github-forked/jdk/src/hotspot/share/classfile/bytecodeAssembler.cpp:85:26:
>
> Yasumasa Suenaga has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Calculate char offset before realloc()
Thanks for all to review this PR! I think we should separate this issue as
following:
* Suppress warnings
* make/modules/java.desktop/lib/Awt2dLibraries.gmk
* src/hotspot/share/classfile/bytecodeAssembler.cpp
* src/hotspot/share/classfile/classFileParser.cpp
*
src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp
* src/hotspot/share/opto/memnode.cpp
* src/hotspot/share/opto/type.cpp
* src/hotspot/share/utilities/compilerWarnings.hpp
* src/hotspot/share/utilities/compilerWarnings_gcc.hpp
* src/java.base/unix/native/libjli/java_md_common.c
* Bug fixes
* src/java.base/share/native/libjli/java.c
* src/java.base/share/native/libjli/parse_manifest.c
* src/jdk.jpackage/linux/native/applauncher/LinuxPackage.c
I want to include the change of Awt2dLibraries.gmk (HarfBuzz) in this PR
because it is 3rd party library.
I will separate in above if I do not hear any objections, and this issue (PR)
handles "suppress warnings" only.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8646
