On Thu, 12 May 2022 01:29:13 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Calculate char offset before realloc()
>
> Thanks for all to review this PR! I think we should separate this issue as 
> following:
> 
> * Suppress warnings
>     * make/modules/java.desktop/lib/Awt2dLibraries.gmk
>     * src/hotspot/share/classfile/bytecodeAssembler.cpp
>     * src/hotspot/share/classfile/classFileParser.cpp
>     * 
> src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdBits.inline.hpp
>     * src/hotspot/share/opto/memnode.cpp
>     * src/hotspot/share/opto/type.cpp
>     * src/hotspot/share/utilities/compilerWarnings.hpp
>     * src/hotspot/share/utilities/compilerWarnings_gcc.hpp
>     * src/java.base/unix/native/libjli/java_md_common.c
> * Bug fixes
>     * src/java.base/share/native/libjli/java.c
>     * src/java.base/share/native/libjli/parse_manifest.c
>     * src/jdk.jpackage/linux/native/applauncher/LinuxPackage.c
> 
> I want to include the change of Awt2dLibraries.gmk (HarfBuzz) in this PR 
> because it is 3rd party library.
> 
> I will separate in above if I do not hear any objections, and this issue (PR) 
> handles "suppress warnings" only.

@YaSuenag From my PoV this sounds like a good suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8646

Reply via email to