On Sun, 13 Nov 2022 22:58:11 GMT, David Holmes <[email protected]> wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> ATTRIBUTE_SCANF
>
> src/hotspot/os/linux/os_perf_linux.cpp line 233:
>
>> 231: * Ensure that 'fmt' does _NOT_ contain the first two "%d %s"
>> 232: */
>> 233: SCANF_ARGS(2, 0) static int vread_statdata(const char* procfile,
>> _SCANFMT_ const char* fmt, va_list args) {
>
> If `SCANF_ARGS` can/must come first then I suggest adding a newline after it
> so the method signature is easier to spot. Applied everywhere of course.
Resolved, thanks
-------------
PR: https://git.openjdk.org/jdk/pull/11081
