On Tue, 15 Nov 2022 06:12:52 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Reverted to use the original, less intrusive solution from >> [8274980](https://github.com/openjdk/jdk/pull/11081/commits/83ed3deb29d7344bbc95a3831f2388d077bc59e9) >> that initially could not work with the older Visual C++ compiler (With a >> minor improvement to handle #define 0) > > Sorry, but I don't think that's much better than the prior version, and still > doesn't seem better than the current code. What problem is this change > supposed to be solving? I didn't find any open bugs that seemed relevant > (could be I just didn't recognize such). Whatever it is seems likely to be > unrelated to any of the other changes in this PR; it would have been / would > be better to deal with it separately. It's related to the JEP-223 version build numbers, which the original commit couldn't get to work due to a preprocessor trick not working with the now unsupported 2017. I just felt it could be included here out of convenience, but I guess I can split it off into another change if required ------------- PR: https://git.openjdk.org/jdk/pull/11081
