On Wed, 16 Nov 2022 19:32:18 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into util >> - Squash > > make/autoconf/jdk-version.m4 line 84: > >> 82: DEFAULT: $USERNAME, >> 83: DESC: [build username to use in version strings], >> 84: IF_GIVEN: [ > > In general, I think these tests would be better expressed using the > `CHECK_VALUE` construct, rather than `IF_GIVEN`. (A more specific reason is > better than a vaguer and more general) Something concerning is happening when I do that: The code in the CHECK_VALUE block from the resulting configure script has all of the square brackets completely nuked, which is causing the logic in it to always fail. Switching back to IF_GIVEN on my end doesn't help either, it now always destroys all the brackets as well when it was working fine before. Something might be going wrong in the actual utility itself, but I can't tell what exactly :/ ------------- PR: https://git.openjdk.org/jdk/pull/11020
