On Sat, 12 Nov 2022 16:18:54 GMT, Julian Waters <jwat...@openjdk.org> wrote:

>> 8285093 introduced the new UTIL_ARG_WITH definition, which was not available 
>> when both 8282948 and 8282700 were written. They can now be moved to using 
>> the cleaner logic that UTIL_ARG_WITH grants.
>> 
>> There are many more options that still use AC_ARG_WITH in jdk-version.m4. 
>> They are out of the scope of this commit, which aims only to rework the 
>> previous integrated commits mentioned above.
>
> Julian Waters has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains two additional 
> commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into util
>  - Squash

make/autoconf/jdk-version.m4 line 95:

> 93:   UTIL_ARG_WITH(NAME: jdk-rc-name, TYPE: string,
> 94:     DEFAULT: [$PRODUCT_NAME $JDK_RC_PLATFORM_NAME],
> 95:     DESC: [Set JDK RC name. This is used for FileDescription and 
> ProductName

Please use `DEFAULT_DESC` instead of the old `@<:@...@:>@` construct. (This too 
goes for all the instances)

-------------

PR: https://git.openjdk.org/jdk/pull/11020

Reply via email to