On Fri, 25 Nov 2022 13:24:09 GMT, Christoph Langer <clan...@openjdk.org> wrote:
> This is an attempt to fix the issue reported in JDK-8291444. > > The check for secrets.JDK_SUBMIT_FILTER should only be applied to the push > event but not on e.g. workflow_dispatch. > Currently setting JDK_SUBMIT_FILTER would lead to setting every platform to > 'false', even when manually triggering the GHA run via workflow_dispatch. > > I furthermore propose to relax the check for unknown events. In OpenJDK we > only use/define workflow_dispatch and push. Other events would hence not > trigger the workflow anyway. However, downstream vendors (like us in > SapMachine) might use other events such as pull_request and they would then > need to patch this away. This kind of downstream issue was also reported by > [Amazon](https://mail.openjdk.org/pipermail/build-dev/2022-August/035102.html). > If you agree, I would remove the commented lines 91-93. Otherwise I have to > uncomment them. Marked as reviewed by ihse (Reviewer). > If you agree, I would remove the commented lines 91-93. Yes, that sounds good. Please remove the commented lines. (I could have sworn I had already replied this, but either I forgot to press the green button, or I did it on the mobile and had connectivity issues I did not realize) ------------- PR: https://git.openjdk.org/jdk/pull/11365
