> This is an attempt to fix the issue reported in JDK-8291444. > > The check for secrets.JDK_SUBMIT_FILTER should only be applied to the push > event but not on e.g. workflow_dispatch. > Currently setting JDK_SUBMIT_FILTER would lead to setting every platform to > 'false', even when manually triggering the GHA run via workflow_dispatch. > > I furthermore propose to relax the check for unknown events. In OpenJDK we > only use/define workflow_dispatch and push. Other events would hence not > trigger the workflow anyway. However, downstream vendors (like us in > SapMachine) might use other events such as pull_request and they would then > need to patch this away. This kind of downstream issue was also reported by > [Amazon](https://mail.openjdk.org/pipermail/build-dev/2022-August/035102.html). > If you agree, I would remove the commented lines 91-93. Otherwise I have to > uncomment them.
Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Remove commented lines - Merge branch 'master' into gha-events - JDK-8291444 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/11365/files - new: https://git.openjdk.org/jdk/pull/11365/files/5369e338..d796fedd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11365&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11365&range=00-01 Stats: 24102 lines in 710 files changed: 14002 ins; 6550 del; 3550 mod Patch: https://git.openjdk.org/jdk/pull/11365.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11365/head:pull/11365 PR: https://git.openjdk.org/jdk/pull/11365
